Skip to content

Adds support for PHP files (.php and .twig) - #94

Open
MrDys wants to merge 1 commit into
MemPalace:developfrom
MrDys:feature-php
Open

Adds support for PHP files (.php and .twig)#94
MrDys wants to merge 1 commit into
MemPalace:developfrom
MrDys:feature-php

Conversation

@MrDys

@MrDys MrDys commented Apr 7, 2026

Copy link
Copy Markdown

What does this PR do?

Adds support for the miner to look at PHP files (.php and .twig)

How to test

Run mempalace mine on a PHP codebase.

Checklist

  • Tests pass (python -m pytest tests/ -v)
  • No hardcoded paths
  • Linter passes (ruff check .)

@bensig

bensig commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

CI is green — nice work! There's a merge conflict with main though (miner.py changed upstream). Can you rebase on main and push?

@web3guru888 web3guru888 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Review of #94Adds support for PHP files (.php and .twig)

Scope: +4/−0 · 2 file(s)

  • mempalace/miner.py (modified: +2/−0)
  • tests/test_miner.py (modified: +2/−0)

Strengths

  • ✅ Includes test coverage

🟢 Approved — clean, well-structured PR. Good work @MrDys!


🏛️ Reviewed by MemPalace-AGI · Autonomous research system with perfect memory · Showcase: Truth Palace of Atlantis

@bensig
bensig changed the base branch from main to develop April 11, 2026 22:23
@igorls igorls added enhancement New feature or request area/mining File and conversation mining labels Apr 14, 2026
@igorls

igorls commented May 8, 2026

Copy link
Copy Markdown
Member

Hi, thanks for the contribution.

This PR has merge conflicts with develop, and the branch has not been updated in over 7 days, which puts it before our most recent release. The conflicts are likely against work that landed in that release.

Could you rebase onto develop so we can take another look?

If this change is no longer relevant, feel free to close the PR.

(This message is part of a periodic backlog pass, sent to all open PRs that match this state.)

@igorls igorls added the needs-rebase PR has merge conflicts with develop and needs rebase label May 8, 2026
@ManuelReschke

Copy link
Copy Markdown
Contributor

@MrDys please fix it :=) i need also the php indexing 👍 Thanks

@ManuelReschke

Copy link
Copy Markdown
Contributor

@igorls hey, just close this PR here, the dev is inactive. I open a new one. Please review and merge, thanks. #1819

@igorls

igorls commented Aug 15, 2026

Copy link
Copy Markdown
Member

Thanks for this contribution, and apologies for the slow turnaround.

develop has moved a fair way since this was opened and the branch no longer merges cleanly. If you're still interested in landing it, could you rebase onto current develop? Once it merges cleanly and CI is green I'll get it reviewed for the 3.8.0 cycle.

If you'd rather not pick it back up, no problem at all — just say so and I'll close it out, and thanks either way for taking the time to send it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/mining File and conversation mining enhancement New feature or request needs-rebase PR has merge conflicts with develop and needs rebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants