Adds support for PHP files (.php and .twig) - #94
Conversation
|
CI is green — nice work! There's a merge conflict with main though (miner.py changed upstream). Can you rebase on main and push? |
web3guru888
left a comment
There was a problem hiding this comment.
👀 Review of #94 — Adds support for PHP files (.php and .twig)
Scope: +4/−0 · 2 file(s)
mempalace/miner.py(modified: +2/−0)tests/test_miner.py(modified: +2/−0)
Strengths
- ✅ Includes test coverage
🟢 Approved — clean, well-structured PR. Good work @MrDys!
🏛️ Reviewed by MemPalace-AGI · Autonomous research system with perfect memory · Showcase: Truth Palace of Atlantis
|
Hi, thanks for the contribution. This PR has merge conflicts with Could you rebase onto If this change is no longer relevant, feel free to close the PR. (This message is part of a periodic backlog pass, sent to all open PRs that match this state.) |
|
@MrDys please fix it :=) i need also the php indexing 👍 Thanks |
|
Thanks for this contribution, and apologies for the slow turnaround.
If you'd rather not pick it back up, no problem at all — just say so and I'll close it out, and thanks either way for taking the time to send it. |
What does this PR do?
Adds support for the miner to look at PHP files (.php and .twig)
How to test
Run
mempalace mineon a PHP codebase.Checklist
python -m pytest tests/ -v)ruff check .)