test: add palace_graph ranking and limits coverage - #916
Merged
Conversation
fatkobra
requested review from
bensig,
igorls and
milla-jovovich
as code owners
April 15, 2026 16:00
igorls
added a commit
that referenced
this pull request
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds focused tests for ranking and limit behavior in
mempalace/palace_graph.py.Covered:
find_tunnels()sorting by descending countfind_tunnels()result cap at 50graph_stats()["rooms_per_wing"]graph_stats()["top_tunnels"]only including multi-wing rooms and capping at 10How to test
Validation:
ruff format tests/test_palace_graph_limits.pyruff check tests/test_palace_graph_limits.pyruff format --check tests/test_palace_graph_limits.pypython -m pytest tests/test_palace_graph_limits.py -vpython -m pytest tests/test_palace_graph.py tests/test_palace_graph_limits.py -vpython -m pytest tests/ -vNo production code changes.
Checklist
python -m pytest tests/ -v)ruff check .)