fix: use permissive validator for KG entity values - #873
Merged
igorls merged 1 commit intoApr 14, 2026
Conversation
sha2fiddy
marked this pull request as ready for review
April 14, 2026 13:29
sha2fiddy
requested review from
bensig,
igorls and
milla-jovovich
as code owners
April 14, 2026 13:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sanitize_kg_value()inconfig.py— a permissive validator for knowledge graph subject/object fields that allows punctuation (commas, colons, parentheses, slashes,#, etc.) while still blocking null bytes and enforcing the 128-char length limitmcp_server.pyKG tools (kg_add,kg_invalidate,kg_query,kg_timeline) to usesanitize_kg_valuefor subject/object/entity fields; predicates still use the strictsanitize_namesanitize_namewas designed for wing/room names with filesystem constraints — KG entity values live in SQLite and don't need those restrictionsCloses #455
Test plan
sanitize_kg_value: accepts commas, colons, parens, slashes,#, Unicode; rejects empty, whitespace-only, null bytes, over-lengthruff checkcleanruff format --checkclean