fix: implement ping method in MCP server - #726
Closed
arnoldwender wants to merge 1 commit into
Closed
Conversation
MCP clients such as AnythingLLM v1.12.0 send a ping health-check on connect. Without a handler the server returns -32601 Unknown method, which causes the client to restart the server in a loop. Respond with an empty result object as the MCP spec requires. Fixes MemPalace#584
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
pinghandler to the MCP stdio dispatch loop.MCP clients such as AnythingLLM v1.12.0 send a
pinghealth-check immediately after connecting. Without a handler the server returns{"code": -32601, "message": "Unknown method: ping"}, which causes the client to kill and restart the server in an infinite loop.The fix adds a single branch that responds with an empty result object, as specified by the MCP protocol:
{"jsonrpc": "2.0", "id": <req_id>, "result": {}}Fixes #584
How to test
ping) to the serverOr directly:
Checklist
python -m pytest tests/ -v)ruff check .)