Skip to content

fix: skip arg whitelist for handlers accepting **kwargs (#572) #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bensig merged 2 commits into from
Apr 12, 2026
Merged

fix: skip arg whitelist for handlers accepting **kwargs (#572) #684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5374e8c
fix: skip arg whitelist for handlers accepting **kwargs (#572)
jphein Apr 12, 2026
7096540
fix: guard inspect.signature failure, default to filtering
jphein Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion mempalace/mcp_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1350,8 +1350,21 @@ def handle_request(request):
}
# Whitelist arguments to declared schema properties only.
# Prevents callers from spoofing internal params like added_by/source_file.
# Skip filtering if handler explicitly accepts **kwargs (pass-through).
# Default to filtering on inspect failure (safe fallback).
import inspect

schema_props = TOOLS[tool_name]["input_schema"].get("properties", {})
tool_args = {k: v for k, v in tool_args.items() if k in schema_props}
try:
handler = TOOLS[tool_name]["handler"]
sig = inspect.signature(handler)
accepts_var_keyword = any(
p.kind == inspect.Parameter.VAR_KEYWORD for p in sig.parameters.values()
)
except (ValueError, TypeError):
accepts_var_keyword = False
if not accepts_var_keyword:
tool_args = {k: v for k, v in tool_args.items() if k in schema_props}
# Coerce argument types based on input_schema.
# MCP JSON transport may deliver integers as floats or strings;
# ChromaDB and Python slicing require native int.
Expand Down