Add Rust, Swift, and Xcode build dirs to SKIP_DIRS - #65
Open
shrhoads wants to merge 3 commits into
Open
Conversation
Add `target` (Rust/Cargo), `Pods` (CocoaPods), `.build` (Swift PM), and `DerivedData` (Xcode) to all SKIP_DIRS sets across miner, convo_miner, entity_detector, and room_detector_local. Without these, mining a project with a Rust `target/` directory (often 5+ GB of compiled artifacts) causes extreme memory usage, bloated HNSW indexes, and eventual segfaults. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
Probably best long term fix is to add custom exclude dirs in yaml settings. |
Contributor
|
Tests pass but lint fails — the long SKIP_DIRS line in room_detector_local.py needs formatting. A quick |
web3guru888
approved these changes
Apr 11, 2026
web3guru888
left a comment
There was a problem hiding this comment.
👀 Review of #65 — Add Rust, Swift, and Xcode build dirs to SKIP_DIRS
Scope: +17/−1 · 4 file(s)
mempalace/convo_miner.py(modified: +4/−0)mempalace/entity_detector.py(modified: +4/−0)mempalace/miner.py(modified: +4/−0)mempalace/room_detector_local.py(modified: +5/−1)
🟢 Approved — clean, well-structured PR. Good work @shrhoads!
🏛️ Reviewed by MemPalace-AGI · Autonomous research system with perfect memory · Showcase: Truth Palace of Atlantis
shrhoads
commented
Apr 19, 2026
shrhoads
left a comment
Author
There was a problem hiding this comment.
Resolved merge from develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target(Rust/Cargo),Pods(CocoaPods),.build(Swift PM), andDerivedData(Xcode) to allSKIP_DIRSsetsminer.py,convo_miner.py,entity_detector.py, androom_detector_local.pyProblem
Mining a project containing a Rust
target/directory (commonly 5+ GB of compiled artifacts and intermediate build files) causes:link_lists.binindex (500+ GB in my case)The existing
SKIP_DIRScovers JS/Python/Next.js build dirs but misses common compiled-language equivalents.Test plan
mempalace mine . --dry-runscans 346 files instead of tens of thousands after this change🤖 Generated with Claude Code