-
Notifications
You must be signed in to change notification settings - Fork 7.6k
fix: standalone bug fixes (#534 #535 #536 #538 #570 #572 #637) #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -157,7 +157,6 @@ | |
| r"i need", | ||
| r"never told anyone", | ||
| r"nobody knows", | ||
| r"\*[^*]+\*", | ||
| ] | ||
|
|
||
| ALL_MARKERS = { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -119,8 +119,8 @@ def _load_known_names() -> set: | |
|
|
||
| reg = EntityRegistry.load() | ||
| names = set() | ||
| for entity in reg._data.get("entities", {}).values(): | ||
| names.add(entity.get("canonical", "").lower()) | ||
| for name, entity in reg._data.get("people", {}).items(): | ||
| names.add(name.lower()) | ||
| for alias in entity.get("aliases", []): | ||
| names.add(alias.lower()) | ||
| return names | ||
|
Comment on lines
120
to
126
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Windows-encoding fix replaces the checkmark in
convo_miner.py, butmempalace/miner.pystill prints a Unicode checkmark ("✓") in its progress output. This means the cp1251/cp1252 crash described in #535 is likely still reproducible for project mining; either updateminer.pyas well or adjust the PR description/scope.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct — miner.py's checkmark is addressed in PR #629 (performance) which modifies that file. This PR only touches convo_miner.py and split_mega_files.py.