Skip to content

fix: correct agent-facing instructions in SKILL.md and init/mine docs - #560

Closed
sha2fiddy wants to merge 1 commit into
MemPalace:developfrom
sha2fiddy:fix/534-skill-md-agent-instructions
Closed

fix: correct agent-facing instructions in SKILL.md and init/mine docs#560
sha2fiddy wants to merge 1 commit into
MemPalace:developfrom
sha2fiddy:fix/534-skill-md-agent-instructions

Conversation

@sha2fiddy

@sha2fiddy sha2fiddy commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #534 — three issues in agent-facing documentation that cause failures when agents follow the instructions:

  • SKILL.md: Changed mempalace --version to mempalace status — the CLI has no --version flag, so the prerequisite check always failed
  • init.md: Changed mempalace init <dir> to mempalace init --yes <dir> — without --yes, agents hit EOFError because there is no TTY for interactive prompts
  • mine.md: Added a prerequisite note that mempalace init must be run before mining, so agents don't attempt to mine into an uninitialized palace

Test plan

  • Verify mempalace status works as an install check (returns non-zero if not installed)
  • Verify mempalace init --yes <dir> completes non-interactively
  • Confirm mine instructions now reference the init prerequisite

@web3guru888 web3guru888 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha2fiddy's fixes are all correct on their merits — the three substitutions (mempalace status in SKILL.md, --yes in init.md, and the mine.md prerequisite note) are exactly right.

This overlaps with #559 (adiKhan12), submitted at roughly the same time and addressing the same three issues — worth flagging for @milla-jovovich to pick an approach. The key difference: #560 is a clean docs-only fix, while #559 goes a step further and adds actual argparse support so --version works as a real CLI flag (plus behavioral tests). If the project wants to close the underlying code gap, #559 does that; if docs-only is preferred, #560 is lighter and gets the job done.

Either way, the prerequisite call-out in mine.md and the --yes flag for agent contexts are good catches that should land regardless of which PR is merged.

@sha2fiddy
sha2fiddy marked this pull request as ready for review April 10, 2026 18:33
@jphein

jphein commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

Note: #562 includes overlapping fixes to SKILL.md and init instructions.

@bensig
bensig changed the base branch from main to develop April 11, 2026 22:21
@sha2fiddy

Copy link
Copy Markdown
Contributor Author

Closing — issue #534 was closed by the maintainer, and the remaining work is tracked in #632.

@sha2fiddy sha2fiddy closed this Apr 13, 2026
@sha2fiddy
sha2fiddy deleted the fix/534-skill-md-agent-instructions branch April 18, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SKILL.md uses nonexistent mempalace --version; init instructions omit --yes so agents hit EOFError

3 participants