Skip to content

fix: resolve 6 community-reported bugs #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leopechnicki wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: resolve 6 community-reported bugs #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4135da
fix: resolve 6 community-reported bugs
leopechnicki Apr 10, 2026
b89c668
fix: address PR review feedback — shared pagination, stopword specifi…
leopechnicki Apr 10, 2026
044a87e
fix: address reviewer feedback on PR #518
leopechnicki Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mempalace/entity_detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,19 @@ def _get_stopwords(languages: tuple) -> frozenset:
DIALOGUE_PATTERNS = list(_EN["dialogue_patterns"])
PROJECT_VERB_PATTERNS = list(_EN["project_verb_patterns"])
STOPWORDS = set(_EN["stopwords"])
# GENERIC_STOPWORDS and TECHNICAL_STOPWORDS are backward-compat aliases.
# The stopwords list in en.json merges both; split here for callers that
# override technical terms independently.
GENERIC_STOPWORDS = STOPWORDS
TECHNICAL_STOPWORDS = STOPWORDS



# ==================== EXTENSION POINTS (not language-scoped) ====================

# Combined set used by the detector
STOPWORDS = GENERIC_STOPWORDS | TECHNICAL_STOPWORDS

# For entity detection — prose only, no code files
# Code files have too many capitalized names (classes, functions) that aren't entities
PROSE_EXTENSIONS = {
Expand Down
Loading