fix: modernize ChromaDB API — get_or_create_collection + upsert - #48
Closed
adv3nt3 wants to merge 1 commit into
Closed
fix: modernize ChromaDB API — get_or_create_collection + upsert#48adv3nt3 wants to merge 1 commit into
adv3nt3 wants to merge 1 commit into
Conversation
Replace try/get_collection/except/create_collection with get_or_create_collection() in both miner.py and convo_miner.py. Single atomic call, no broad except Exception needed. Replace collection.add() with collection.upsert() for idempotent writes. Removes try/except handling for "already exists" errors — upsert inserts new records and updates existing ones gracefully. Both APIs recommended by ChromaDB docs and available since v0.4.0 (project requires >=0.4.0).
Contributor
|
Good idea — this overlaps with igorls' #140 which covers upsert + deterministic IDs. Closing to avoid duplicate work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
try: get_collection/except: create_collectionwithget_or_create_collection()in bothminer.pyandconvo_miner.py. Single atomic call, no broadexcept Exceptionneeded.collection.add()withcollection.upsert()for idempotent writes. Removes try/except handling for "already exists" errors — upsert inserts new records and updates existing ones gracefully.>=0.4.0).Changes
2 files changed, 34 insertions, 49 deletions. Net reduction of 15 lines of error-handling boilerplate.
Test plan
ruff check mempalace/miner.py mempalace/convo_miner.pypasses cleanruff format --check mempalace/miner.py mempalace/convo_miner.pyalready formattedpython3 -m py_compile mempalace/miner.pycompiles OKpython3 -m py_compile mempalace/convo_miner.pycompiles OKchromadb>=0.4.0in pyproject.toml confirms both APIs are available