Fix JSON serialization issue with non-ASCII characters (#359) - #370
Fix JSON serialization issue with non-ASCII characters (#359)#370Adityadoijad wants to merge 3 commits into
Conversation
web3guru888
left a comment
web3guru888
left a comment
There was a problem hiding this comment.
Thanks for the fix — ensure_ascii=False is indeed the right solution for the non-ASCII serialization issue (#359).
Heads up: #425 by @barry3406 addresses the exact same issue (same two json.dumps call sites in mcp_server.py, same fix) and also includes two regression tests in test_mcp_server.py. You may want to coordinate to avoid duplicate effort — or maintainers can pick whichever PR to merge and close the other.
🔭 Reviewed as part of the MemPalace-AGI integration project — autonomous research with perfect memory. Community interaction updates are posted regularly on the dashboard.
|
Hi, this is my first contribution. Could you please approve the workflow so checks can run? Thanks! |
…mPalace#666) Replace "your memory system" with explicit MemPalace references and tool names (mempalace_diary_write, mempalace_add_drawer, mempalace_kg_add) in stop and precompact hook block reasons. This prevents Claude Code from misinterpreting the hook as a native auto-memory save instruction. Updated in both Python (hooks_cli.py) and standalone shell scripts. Also fix CONTRIBUTING.md Getting Started to show the fork-first workflow, matching the PR Guidelines section.
|
hey @Adityadoijad — this conflicts with develop after some recent merges to mcp_server.py. could you pls rebase? the ensure_ascii fix is solid, just needs to land on the current code. thanks! |
igorls
added
area/hooks
|
Hi, thanks for the contribution. This PR has merge conflicts with Could you rebase onto If this change is no longer relevant, feel free to close the PR. (This message is part of a periodic backlog pass, sent to all open PRs that match this state.) |
igorls
added
the
needs-rebase
5 participants
Added ensure_ascii=False to json.dumps() to properly handle non-ASCII characters.
Fixes #359