feat: Add mempalace-mcp entry point for standalone MCP server - #313
feat: Add mempalace-mcp entry point for standalone MCP server#313bmaltais wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new installable CLI entry point for running the MemPalace MCP server directly (instead of python -m mempalace.mcp_server), and updates the UV lockfile metadata accordingly.
Changes:
- Add
mempalace-mcpconsole script pointing atmempalace.mcp_server:main. - Update
uv.lockmetadata to include thespellcheckextra (autocorrect) and reflect current dependency constraints (includingchromadbrange).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Adds the mempalace-mcp entry point for standalone MCP server execution. |
| uv.lock | Locks autocorrect / spellcheck extra and updates packaged metadata/dependency constraints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
web3guru888
left a comment
There was a problem hiding this comment.
Thank you for this PR! Adding mempalace-mcp as an entry script is an excellent QoL improvement for both standalone usage and configuring Claude Code.
I've reviewed the changes, and the documentation updates as well as the project.scripts setup mapping mempalace-mcp to mempalace.mcp_server:main look completely correct.
However, I noticed that the PR includes some unrelated package/dependency modifications in pyproject.toml and uv.lock:
- Adding an
autocorrectdependency and a newspellcheckextra. - Narrowing the
chromadbversion bounds from>=0.4.0,<1to>=0.5.0,<0.7. This could introduce runtime conflicts for other integration setups (we are actually tracking a ChromaDB version gap in issue #257).
Given our current strong focus on base stability, we need to keep changes scoped tightly. Could you please revert the dependency changes (autocorrect, spellcheck, and the chromadb bounds) in both pyproject.toml and uv.lock?
If the spellcheck feature or the ChromaDB version bump is needed for other functionality you are working on, those would be best proposed in a separate PR so we can evaluate them independently.
Once the dependency changes are reverted to match main, I will be happy to approve and merge this!
web3guru888
left a comment
There was a problem hiding this comment.
Thank you for this PR! Adding mempalace-mcp as an entry script is an excellent QoL improvement for both standalone usage and configuring Claude Code.
I've reviewed the changes, and the documentation updates as well as the project.scripts setup mapping mempalace-mcp to mempalace.mcp_server:main look completely correct.
However, I noticed that the PR includes some unrelated package/dependency modifications in pyproject.toml and uv.lock:
- Adding an
autocorrectdependency and a newspellcheckextra. - Narrowing the
chromadbversion bounds from>=0.4.0,<1to>=0.5.0,<0.7. This could introduce runtime conflicts for other integration setups (we are actually tracking a ChromaDB version gap in issue #257).
Given our current strong focus on base stability, we need to keep changes scoped tightly. Could you please revert the dependency changes (autocorrect, spellcheck, and the chromadb bounds) in both pyproject.toml and uv.lock?
If the spellcheck feature or the ChromaDB version bump is needed for other functionality you are working on, those would be best proposed in a separate PR so we can evaluate them independently.
Once the dependency changes are reverted to match main, I will be happy to approve and merge this!
bf61485 to
7a01954
Compare
6044348 to
a3f1793
Compare
Add [project.scripts] entry point for mempalace-mcp so the MCP server can be run directly after installation instead of requiring 'python -m mempalace.mcp_server'. This enables: - Cleaner MCP server configuration with just 'mempalace-mcp' as the command - System-wide CLI availability without venv path dependencies - Consistent with other Python package conventions for CLI tools
|
Hey @bmaltais — I've taken a look and ran it through CLI. Thanks for the fix! There are two open PRs addressing #296 and going with #315 because it adds Your |
Add [project.scripts] entry point for mempalace-mcp so the MCP server can be run directly after installation instead of requiring 'python -m mempalace.mcp_server'.
This enables:
mempalace-mcpas the commandpython -m mempalace.mcp_serverdependenciesWhat does this PR do?
How to test
Checklist
python -m pytest tests/ -v)ruff check .)