Skip to content

Add community skill: mempalace-memory behavioral protocol - #222

Closed
Andzdes wants to merge 1 commit into
MemPalace:developfrom
Andzdes:community/mempalace-memory-skill
Closed

Add community skill: mempalace-memory behavioral protocol#222
Andzdes wants to merge 1 commit into
MemPalace:developfrom
Andzdes:community/mempalace-memory-skill

Conversation

@Andzdes

@Andzdes Andzdes commented Apr 8, 2026

Copy link
Copy Markdown

What does this PR do?

Adds a community behavioral skill (SKILL.md) for AI agents using MemPalace MCP, under examples/skills/mempalace-memory/.

Skill repo: https://github.com/Andzdes/mempalace-skill

Without a behavioral protocol, agents using MemPalace MCP:

  • Invent room names (my-auth-stuff instead of canonical auth)
  • Search globally instead of scoping by wing/room
  • Silently overwrite outdated facts without preserving history
  • Store debug noise and chain-of-thought as memories

This skill enforces 9 rules that fix this — retrieval-before-answer, canonical taxonomy, temporal fact safety, write routing, and AAAK compression format.

Compatible with: Antigravity · Claude Code · Cursor · OpenCode

How to test

cp -r examples/skills/mempalace-memory/ ~/.claude/skills/mempalace-memory/

Then ask Claude: "What did we decide about auth?" — with MemPalace running, it retrieves instead of hallucinating.

@bgauryy

bgauryy commented Apr 8, 2026

Copy link
Copy Markdown

PR Review: Add community skill — mempalace-memory behavioral protocol

Executive Summary

Aspect Value
PR Goal Add a community-contributed SKILL.md behavioral protocol for AI agents using MemPalace MCP
Files Changed 2 (both new)
Risk Level 🟡 MEDIUM — no code changes, but factual inaccuracies will actively misguide agents adopting this skill
Review Effort 2/5 — small PR, documentation only
Recommendation 🔄 REQUEST_CHANGES

Affected Areas: examples/skills/mempalace-memory/SKILL.md, examples/skills/mempalace-memory/README.md

Business Impact: Community skills shipped in-repo carry implicit endorsement. Agents following incorrect room names or hall names will create inconsistent palace data across users.

Flow Changes: None — no code is modified. This is a new documentation artifact.

Ratings

Aspect Score
Correctness 2/5
Security 4/5
Performance N/A
Maintainability 3/5

PR Health

High Priority Issues

(Must fix before merge)

🐛 #1: [REDACTED-REDISAUTHPASSWORD] artifact in canonical room list

Location: examples/skills/mempalace-memory/SKILL.md:67 | Confidence: ✅ HIGH

A secret scanner false-positive left a [REDACTED-REDISAUTHPASSWORD] placeholder in the middle of the canonical room names list. The original word was almost certainly auth (a standard room for authentication code). This artifact exists in the contributor's source repo as well.

  Standard rooms for technical projects:
  architecture backend frontend database infra deploy
- [REDACTED-REDISAUTHPASSWORD] testing bugs product users team-process
+ auth testing bugs product users team-process

🐛 #2: Canonical room list diverges from actual FOLDER_ROOM_MAP

Location: examples/skills/mempalace-memory/SKILL.md:65-67 | Confidence: ✅ HIGH

The SKILL.md invents room names that don't match the canonical rooms defined in mempalace/room_detector_local.py. Agents following this list will create non-canonical rooms, defeating the purpose of Section 5 ("do not invent local naming conventions").

Rooms listed in SKILL.md but NOT canonical in FOLDER_ROOM_MAP:

  • architecture — not mapped
  • database — maps to backend
  • infra — maps to configuration
  • deploy — maps to configuration
  • bugs — not mapped
  • product — not mapped
  • users — not mapped
  • team-process — partially maps to team

Actual canonical rooms missing from SKILL.md:
documentation, design, costs, meetings, research, planning, scripts, configuration

  Standard rooms for technical projects:
- architecture backend frontend database infra deploy
- auth testing bugs product users team-process
+ backend frontend documentation design configuration
+ testing research planning scripts costs meetings team

Note: The exact canonical list should be derived from the unique values of FOLDER_ROOM_MAP to stay in sync.


🐛 #3: Hall name mismatch — hall_advice vs hall_assistant_advice

Location: examples/skills/mempalace-memory/SKILL.md:77 | Confidence: ✅ HIGH

The SKILL.md lists hall_advice but the codebase uses hall_assistant_advice (see README.md and benchmarks/HYBRID_MODE.md). Additionally, hall_general is an established hall that is omitted entirely.

  - hall_facts — durable truths and system states
  - hall_events — incidents, decisions, state changes
  - hall_discoveries — learned lessons, root causes
  - hall_preferences — recurring user or team preferences
- - hall_advice — reusable best practices and recommendations
+ - hall_assistant_advice — reusable best practices and recommendations
+ - hall_general — everything else

Medium Priority Issues

(Should fix, not blocking)

🎨 #4: Tool prefix mcp_mempalace_mempalace_* is IDE-specific, not universal

Location: examples/skills/mempalace-memory/SKILL.md (throughout: lines 19, 29-33, 53, 57-59, 80-81, 96-97) | Confidence: ⚠️ MED

The SKILL.md uses the double-prefixed form mcp_mempalace_mempalace_status throughout. This prefix is injected by specific MCP clients (e.g., Claude Code prepends mcp_{server_name}_), but the actual tool names registered by the server are bare mempalace_* (e.g., mempalace_status). The project's own README.md and PALACE_PROTOCOL use bare names.

Since the SKILL.md claims compatibility with Antigravity, Claude Code, Cursor, and OpenCode — each of which may handle prefixing differently — hardcoding a single client's prefix will break for other clients.

Suggestion: Use bare tool names (mempalace_status, mempalace_search, etc.) and add a note that some MCP clients prepend a server-name prefix. Alternatively, use a placeholder like {prefix}mempalace_status with an explanation.


🔗 #5: Significant overlap with built-in PALACE_PROTOCOL

Location: examples/skills/mempalace-memory/SKILL.md:17-101 | Confidence: ⚠️ MED

The MCP server already embeds a PALACE_PROTOCOL string (returned by mempalace_status) with 5 rules that substantially overlap with the SKILL.md's Sections 0, 1, 3, 4, and 7. Where they diverge, the SKILL.md introduces incorrect details (room names, hall names).

This creates a risk of conflicting instructions — an agent loads the built-in protocol from mempalace_status, then also has the SKILL.md active. If the two disagree, agent behavior becomes unpredictable.

Suggestion: Either (a) explicitly position the SKILL.md as a superset that extends (not replaces) the built-in protocol, or (b) remove overlapping sections and focus only on what the built-in protocol doesn't cover (write routing, noise filter, AAAK format, taxonomy lookup).


Low Priority Issues

(Nice to have)

🎨 #6: YAML frontmatter says All tools use prefix mcp_mempalace_

Location: examples/skills/mempalace-memory/SKILL.md:10 | Confidence: ⚠️ MED

The frontmatter compatibility block states "All tools use prefix mcp_mempalace_" but the actual body uses mcp_mempalace_mempalace_* (double prefix). These are inconsistent with each other and with the server's bare names.

  compatibility: >
    Requires MemPalace MCP server running locally (mempalace mcp).
    Configure in ~/.config/mcp/servers.json or IDE-specific MCP config.
-   All tools use prefix mcp_mempalace_.
+   Tool names start with mempalace_ (some MCP clients add a server prefix).

🎨 #7: README install path for Antigravity uses ~/.gemini/skills/

Location: examples/skills/mempalace-memory/README.md:15-16 | Confidence: ❓ LOW

The README maps Antigravity to ~/.gemini/skills/. If Antigravity has changed its skill directory since the Gemini CLI rename, this path may be stale. Minor, but worth a quick check.


Created by Octocode MCP https://octocode.ai 🔍🐙

@web3guru888 web3guru888 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Review of #222Add community skill: mempalace-memory behavioral protocol

Scope: +137/−0 · 2 file(s)

  • examples/skills/mempalace-memory/README.md (added: +36/−0)
  • examples/skills/mempalace-memory/SKILL.md (added: +101/−0)

Suggestions

  • Magic number(s) 2026 — consider extracting to named constant(s)

🟢 Approved — clean, well-structured PR. Good work @Andzdes!


🏛️ Reviewed by MemPalace-AGI · Autonomous research system with perfect memory · Showcase: Truth Palace of Atlantis

@bensig
bensig changed the base branch from main to develop April 11, 2026 22:23
@Andzdes Andzdes closed this Apr 14, 2026
@Andzdes
Andzdes deleted the community/mempalace-memory-skill branch April 14, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants