Skip to content

fix(windows): safely repair legacy mojibake with backups #2148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorls merged 4 commits into from
Aug 3, 2026
Merged

fix(windows): safely repair legacy mojibake with backups #2148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c56f8b3
fix(windows): add legacy encoding repair tool
fatkobra Aug 3, 2026
4497753
fix(encoding): make repair conservative and reversible
fatkobra Aug 3, 2026
67dcaf3
fix(encoding): recover undefined CP1252 continuation bytes
fatkobra Aug 3, 2026
047d733
ci: retry transient Chroma reader initialization failure
igorls Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,18 @@ jobs:
python-version: "3.13"
cache: 'pip'
- run: pip install -e ".[dev]"
# ChromaDB's rust HNSW core intermittently fails compaction on Windows
# ("Failed to apply logs to the hnsw segment writer") regardless of our
# code — a long-standing, non-reproducible-on-Linux/macOS flake. Retry
# ONLY that specific transient error (via --only-rerun) so real,
# ChromaDB's rust HNSW core intermittently fails compaction or reader
# initialization on Windows ("Failed to apply logs to the hnsw segment
# writer" / "Error creating hnsw segment reader: Nothing found on disk")
# regardless of our code — long-standing, non-reproducible-on-Linux/macOS
# flakes. Retry ONLY those specific transient errors (via --only-rerun) so real,
# deterministic failures still fail on the first run. Linux/macOS jobs
# deliberately run with no reruns so genuine regressions surface there.
- run: python -m pytest tests/ -v --ignore=tests/benchmarks --cov=mempalace --cov-report=term-missing --cov-fail-under=80 --durations=10 --reruns 2 --reruns-delay 5 --only-rerun "Failed to apply logs to the hnsw segment writer"
- run: >-
python -m pytest tests/ -v --ignore=tests/benchmarks --cov=mempalace
--cov-report=term-missing --cov-fail-under=80 --durations=10 --reruns 2
--reruns-delay 5 --only-rerun
"Failed to apply logs to the hnsw segment writer|Error creating hnsw segment reader: Nothing found on disk"

test-macos:
runs-on: macos-latest
Expand Down
Loading