fix(embedding): remap unsupported EmbeddingGemma token IDs - #2136
Merged
igorls merged 1 commit intoAug 3, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
<unk>token before invoking ONNX Runtime<image_soft_token>Root cause
The packaged EmbeddingGemma tokenizer defines
<image_soft_token>as added token ID262144.The text-only ONNX export's embedding matrix has 262,144 rows, so valid indices end at
262143.EmbeddinggemmaONNX.__call__()previously passed the tokenizer output directly tosession.run(). When source text contained the literal<image_soft_token>, ONNX Runtime attempted to gather row262144and aborted the complete embedding batch.Implementation
The new helper obtains the text-model boundary with:
How to test
Checklist
python -m pytest tests/ -v)ruff check .)