feat(miner): add C and C++ file extensions to READABLE_EXTENSIONS - #1983
Open
tkirkland wants to merge 1 commit into
Open
feat(miner): add C and C++ file extensions to READABLE_EXTENSIONS#1983tkirkland wants to merge 1 commit into
tkirkland wants to merge 1 commit into
Conversation
The whitelist grew per-stack (C#, PHP, Swift/Kotlin, LaTeX) but never gained C or C++, so mining any C project silently drops every .c/.h file at the scan_project suffix gate — no warning, no log line. Add .c/.h/.cpp/.hpp/.cc/.hh to miner.py and to entity_detector.py's twin list, with a visibility test following test_miner_jsonl_visibility.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
READABLE_EXTENSIONShas grown per-stack over time (C#/.NET in #952, PHP, Swift/Kotlin in #1368, LaTeX) but never gained C or C++. Mining any C project silently drops every.c/.hfile at thescan_projectsuffix gate — no warning, no log line. Found in the wild when a mine run of a directory containing a.cprobe file reported it as neither processed nor visibly skipped.Change
.c .h .cpp .hpp .cc .hhtominer.py:READABLE_EXTENSIONSentity_detector.py's twin list so entity detection sees the same filestests/test_miner_jsonl_visibility.py(whitelist membership +scan_projectpicks up a real.cfile)uv run pytest tests/green locally; ruff check/format clean.Happy to rebase onto the config-driven extensions work (#1420 et al.) if that's landing soon — this just closes the gap in the shipped default list meanwhile.