fix: read-only mode misses checkpoint and delete_by_source in _MUTATING_TOOLS - #1930
Merged
igorls merged 1 commit intoJul 6, 2026
Merged
Conversation
mempalace_checkpoint and mempalace_delete_by_source (added in 3.5.0) were missing from _MUTATING_TOOLS, so a server started with --read-only / MEMPALACE_MCP_READ_ONLY=1 still allowed writing drawers and bulk-deleting by source. The same gap affected the peer-writer lock gate, which uses the same frozenset. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the _parse_args function in mempalace/mcp_server.py to include two new commands: mempalace_checkpoint and mempalace_delete_by_source. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Merged
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mempalace_checkpointandmempalace_delete_by_source(both added in 3.5.0) are missing from_MUTATING_TOOLSinmcp_server.py. As a result, a server started with--read-only/MEMPALACE_MCP_READ_ONLY=1still allows writing drawers (checkpoint) and bulk-deleting them (delete_by_sourcewithdry_run=false). The peer-writer lock gate uses the same frozenset, so it is affected as well.Fix
Add both tool names to the
_MUTATING_TOOLSfrozenset (2 lines, no behavior change outside read-only/peer-writer gating).Context
Found during a security review of the codebase before adopting MemPalace as a hardened read-only recall layer for a personal memory system. Thanks for the project, the defensive engineering elsewhere (restricted unpickler, sanitizers, loopback-anchored HTTP) is genuinely impressive.
🤖 Generated with Claude Code