test: stabilize closet boost fixture on Windows - #1807
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the test test_closet_boost_marks_hit_as_drawer_plus_closet in tests/test_closets.py to use the upsert_closet_lines helper function with multiple high-signal closet lines instead of a single terse pointer to ensure stable ranking across Chroma platform builds. Additionally, the search query in search_memories was updated to 'JWT auth tokens expiry'. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the Windows CI behavior of the hybrid drawer+closet search fixture by making the seeded closet content more keyword-rich and adjusting the query so the closet-boost path is reliably exercised across Chroma platform builds.
Changes:
- Seed the closets collection using
upsert_closet_lines()with multiple high-signal pointer lines rather than a single terse document. - Update the hybrid search query in the test to better overlap with the seeded closet topics while keeping assertions focused on the
matched_via/closet_previewcontract.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
develop@7f5bbd8upsert_closet_lines()instead of one terse raw upsertdrawer+closet/closet_previewcontract rather than borderline Chroma ranking differencesRoot Cause
The
test_closet_boost_marks_hit_as_drawer_plus_closetfixture depended on a single short closet document ranking strongly enough on every Chroma platform build. On Windows, the direct drawer search still returned results, but no hit crossed the closet boost path, leavingboosted == [].Validation
uv run --python 3.13 pytest tests/test_closets.py::TestSearchMemoriesHybrid::test_closet_boost_marks_hit_as_drawer_plus_closet -vuv run --python 3.13 pytest tests/test_closets.py::TestSearchMemoriesHybrid tests/test_hybrid_search.py -vgit diff --checkuv run --python 3.13 ruff check .uv run --python 3.13 ruff format --check .