Skip to content

test: stabilize closet boost fixture on Windows - #1807

Merged
igorls merged 1 commit into
developfrom
codex/develop-341-windows-closet-boost-fix
Jun 14, 2026
Merged

test: stabilize closet boost fixture on Windows#1807
igorls merged 1 commit into
developfrom
codex/develop-341-windows-closet-boost-fix

Conversation

@igorls

@igorls igorls commented Jun 14, 2026

Copy link
Copy Markdown
Member

Summary

  • stabilize the closet-boost hybrid search fixture that failed on Windows CI for develop@7f5bbd8
  • seed the closet with several high-signal pointer lines through upsert_closet_lines() instead of one terse raw upsert
  • keep the assertion focused on the drawer+closet/closet_preview contract rather than borderline Chroma ranking differences

Root Cause

The test_closet_boost_marks_hit_as_drawer_plus_closet fixture depended on a single short closet document ranking strongly enough on every Chroma platform build. On Windows, the direct drawer search still returned results, but no hit crossed the closet boost path, leaving boosted == [].

Validation

  • uv run --python 3.13 pytest tests/test_closets.py::TestSearchMemoriesHybrid::test_closet_boost_marks_hit_as_drawer_plus_closet -v
  • uv run --python 3.13 pytest tests/test_closets.py::TestSearchMemoriesHybrid tests/test_hybrid_search.py -v
  • git diff --check
  • uv run --python 3.13 ruff check .
  • uv run --python 3.13 ruff format --check .

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test test_closet_boost_marks_hit_as_drawer_plus_closet in tests/test_closets.py to use the upsert_closet_lines helper function with multiple high-signal closet lines instead of a single terse pointer to ensure stable ranking across Chroma platform builds. Additionally, the search query in search_memories was updated to 'JWT auth tokens expiry'. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@igorls
igorls marked this pull request as ready for review June 14, 2026 18:22
@igorls
igorls requested a review from milla-jovovich as a code owner June 14, 2026 18:22
Copilot AI review requested due to automatic review settings June 14, 2026 18:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR stabilizes the Windows CI behavior of the hybrid drawer+closet search fixture by making the seeded closet content more keyword-rich and adjusting the query so the closet-boost path is reliably exercised across Chroma platform builds.

Changes:

  • Seed the closets collection using upsert_closet_lines() with multiple high-signal pointer lines rather than a single terse document.
  • Update the hybrid search query in the test to better overlap with the seeded closet topics while keeping assertions focused on the matched_via / closet_preview contract.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@igorls
igorls merged commit 68a971b into develop Jun 14, 2026
9 checks passed
@igorls
igorls deleted the codex/develop-341-windows-closet-boost-fix branch June 14, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants