docs: remove/contextualize external palace-daemon references - #1746
Open
rupivbluegreen wants to merge 1 commit into
Open
docs: remove/contextualize external palace-daemon references#1746rupivbluegreen wants to merge 1 commit into
rupivbluegreen wants to merge 1 commit into
Conversation
Replace references to the external palace-daemon project with self-contained descriptions: - palace_graph.py: replace provenance comment citing palace-daemon's verify-routes.sh with a self-contained description of the bug discovery - test_palace_graph.py: same provenance comment update - docs/recovery/index-metadata-recovery.md: generalize systemctl stop/start commands to not assume palace-daemon, and add context explaining what palace-daemon is in the Related section Closes MemPalace#1603 Signed-off-by: Vipur Kumar <vipurkumar@gmail.com> Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes references to the external palace-daemon service across the documentation, code comments, and test docstrings, replacing them with generic service descriptions or clarifying that palace-daemon is an external third-party tool. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses #1603 — removes or contextualizes confusing references to the external
palace-daemonproject (not shipped with mempalace) across three files:mempalace/palace_graph.py— replaced provenance comment citingpalace-daemon's verify-routes.sh with a self-contained description
tests/test_palace_graph.py— same docstring update in the corresponding testdocs/recovery/index-metadata-recovery.md— generalized systemctl commands,added context explaining what palace-daemon is in the Related section
The chroma.py reference (also listed in #1603) was already removed by #1602.
Closes #1603
How to test
All 24 test_palace_graph.py tests pass. No code logic changed — comments/docs only.
Checklist