Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(mcp): repair diary_write content alias + restore -32602 diagnostic (fixes red develop) #1700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
fix(mcp): repair diary_write content alias + restore -32602 diagnostic (fixes red develop) #1700
Changes from 1 commit
ad9874fb130301File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
not tool_args.get("entry")to check ifentryis provided can lead to unexpected behavior ifentryis explicitly passed as an empty string""(which is falsy). In such cases, thecontentalias will overwrite the explicitly provided emptyentry, violating the rule thatentryshould win if both are supplied.Checking for the presence of the key or checking if the value is explicitly
Noneis more robust.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fallback query returns a
QueryResultobject (which uses attribute access) rather than a plain dictionary. Attempting to access its fields via dict-like subscription (e.g.,raw["documents"]) will raise aTypeErrorat runtime, crashing the fallback path.Using the existing
_first_or_emptyhelper resolves this polymorphism safely for bothQueryResultobjects and dictionary shapes.Uh oh!
There was an error while loading. Please reload this page.