Skip to content

fix: defer KnowledgeGraph init to first use in MCP server #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adv3nt3 wants to merge 1 commit into from
Closed

fix: defer KnowledgeGraph init to first use in MCP server #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions mempalace/mcp_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,19 @@ def _parse_args():
os.environ["MEMPALACE_PALACE_PATH"] = os.path.abspath(_args.palace)

_config = MempalaceConfig()
if _args.palace:
_kg = KnowledgeGraph(db_path=os.path.join(_config.palace_path, "knowledge_graph.sqlite3"))
else:
_kg = KnowledgeGraph()
_kg = None


def _get_kg():
global _kg
if _kg is None:
if _args.palace:
_kg = KnowledgeGraph(
db_path=os.path.join(_config.palace_path, "knowledge_graph.sqlite3")
)
else:
_kg = KnowledgeGraph()
return _kg


_client_cache = None
Expand Down Expand Up @@ -415,7 +424,7 @@ def tool_delete_drawer(drawer_id: str):

def tool_kg_query(entity: str, as_of: str = None, direction: str = "both"):
"""Query the knowledge graph for an entity's relationships."""
results = _kg.query_entity(entity, as_of=as_of, direction=direction)
results = _get_kg().query_entity(entity, as_of=as_of, direction=direction)
return {"entity": entity, "as_of": as_of, "facts": results, "count": len(results)}


Expand All @@ -440,7 +449,7 @@ def tool_kg_add(
"source_closet": source_closet,
},
)
triple_id = _kg.add_triple(
triple_id = _get_kg().add_triple(
subject, predicate, object, valid_from=valid_from, source_closet=source_closet
)
return {"success": True, "triple_id": triple_id, "fact": f"{subject} → {predicate} → {object}"}
Expand All @@ -452,7 +461,7 @@ def tool_kg_invalidate(subject: str, predicate: str, object: str, ended: str = N
"kg_invalidate",
{"subject": subject, "predicate": predicate, "object": object, "ended": ended},
)
_kg.invalidate(subject, predicate, object, ended=ended)
_get_kg().invalidate(subject, predicate, object, ended=ended)
return {
"success": True,
"fact": f"{subject} → {predicate} → {object}",
Expand All @@ -462,13 +471,13 @@ def tool_kg_invalidate(subject: str, predicate: str, object: str, ended: str = N

def tool_kg_timeline(entity: str = None):
"""Get chronological timeline of facts, optionally for one entity."""
results = _kg.timeline(entity)
results = _get_kg().timeline(entity)
return {"entity": entity or "all", "timeline": results, "count": len(results)}


def tool_kg_stats():
"""Knowledge graph overview: entities, triples, relationship types."""
return _kg.stats()
return _get_kg().stats()


# ==================== AGENT DIARY ====================
Expand Down