Skip to content

fix(cli): force UTF-8 when reading/writing .gitignore in init #1648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorls merged 3 commits into from
Jun 28, 2026
Merged

fix(cli): force UTF-8 when reading/writing .gitignore in init #1648

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94cf831
fix(cli): force UTF-8 when reading/writing .gitignore in init
May 29, 2026
888e700
Merge branch 'main' into fix/gitignore-utf8-windows
igorls Jun 28, 2026
1a150ac
Merge branch 'main' into fix/gitignore-utf8-windows
igorls Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions mempalace/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,14 +259,16 @@ def _ensure_mempalace_files_gitignored(project_dir) -> bool:
if not (project_path / ".git").exists():
return False
gitignore = project_path / ".gitignore"
existing = gitignore.read_text() if gitignore.exists() else ""
# Force UTF-8: Windows defaults to GBK and chokes on non-ASCII .gitignore
# comments, killing auto-init even though the file is valid UTF-8.
existing = gitignore.read_text(encoding="utf-8", errors="replace") if gitignore.exists() else ""
existing_lines = {line.strip() for line in existing.splitlines()}
missing = [p for p in _MEMPALACE_PROJECT_FILES if p not in existing_lines]
if not missing:
return False
prefix = "" if not existing or existing.endswith("\n") else "\n"
block = prefix + "\n# MemPalace per-project files (issue #185)\n" + "\n".join(missing) + "\n"
with open(gitignore, "a") as f:
with open(gitignore, "a", encoding="utf-8") as f:
f.write(block)
print(f" Added {', '.join(missing)} to {gitignore.name}")
return True
Expand Down
Loading