Conversation
- Add ContentHashDB with Bloom filter for content-aware deduplication - Add git_miner module for mining git repos commit-by-commit - Integrate ContentHashDB into miner.py and convo_miner.py - Add --mode git and --branch CLI arguments - Add tests for ContentHashDB (12 tests) and git_miner (17 tests)
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a git mining mode and content-based duplicate detection using a Bloom filter and SQLite. Feedback identifies memory concerns when hashing large files, logic errors in the file-skipping mechanism within miner.py and convo_miner.py, and inefficient storage of the Bloom filter. Additionally, it is recommended to chunk large git commit content to ensure better search performance and quality.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
- Save bloom filter as gzip-compressed pickle with SHA256 integrity hash - Add SafeUnpickler that only allows basic built-in types - Reject malicious pickle files that try to execute code - Add tests for malicious pickle rejection and hash verification
daedalus
marked this pull request as draft
May 8, 2026 14:06
- Add chunk_diff() function to split large diffs into smaller pieces - Process_commit now creates multiple drawers per commit (one per chunk) - Add chunking constants: CHUNK_SIZE=2000, CHUNK_OVERLAP=200, MIN_CHUNK_SIZE=50 - Add tests for chunking functionality (TestChunkDiff: 4 tests) - Update dry-run output to show chunk count - Fix return value to reflect total drawers created
daedalus
marked this pull request as ready for review
May 8, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
bloom-filter-v3
mempalace/content_hash.py—BloomFilter+ContentHashDBclassesmempalace/miner.py— integrated ContentHashDB intoprocess_file()andmine()mempalace/convo_miner.py— integrated ContentHashDB intomine_convos()tests/test_hashdb.py— 12 tests (all passing)git-miner
mempalace/git_miner.py— git mining module (334 lines)mempalace/cli.py— addedgitmode,--branchargumenttests/test_git_miner.py— 17 tests (all passing)Usage
Test Results