Skip to content

Feat/add kotlin file support #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fatkobra wants to merge 6 commits into from
Closed

Feat/add kotlin file support #1075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5bec204
add a regression test showing Kotlin files are included by `scan_proj…
fatkobra Apr 21, 2026
47d2983
feat(miner): add Kotlin file support
fatkobra Apr 21, 2026
57d9fa3
add a regression test for Kotlin script files
fatkobra Apr 21, 2026
3fb8a03
also add `.kts` since Kotlin script files are the same ecosystem gap
fatkobra Apr 21, 2026
5df19a5
style: remove trailing whitespace in miner tests
fatkobra Apr 21, 2026
88651c1
Resolve merge conflict with develop
fatkobra May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mempalace/miner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
".html",
".css",
".java",
".kt",
".kts",
".go",
".rs",
".rb",
Expand Down
45 changes: 28 additions & 17 deletions tests/test_miner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,34 @@ def test_scan_project_respects_gitignore():
shutil.rmtree(tmpdir)


def test_scan_project_includes_kotlin_files():
tmpdir = tempfile.mkdtemp()
try:
project_root = Path(tmpdir).resolve()
write_file(
project_root / "src" / "Main.kt",
'fun main() {\n println("hello")\n}\n' * 20,
)

assert scanned_files(project_root) == ["src/Main.kt"]
finally:
shutil.rmtree(tmpdir, ignore_errors=True)


def test_scan_project_includes_kotlin_script_files():
tmpdir = tempfile.mkdtemp()
try:
project_root = Path(tmpdir).resolve()
write_file(
project_root / "scripts" / "build.kts",
'tasks.register("hello") {\n doLast { println("hello") }\n}\n' * 20,
)

assert scanned_files(project_root) == ["scripts/build.kts"]
finally:
shutil.rmtree(tmpdir, ignore_errors=True)


def test_scan_project_respects_nested_gitignore():
tmpdir = tempfile.mkdtemp()
try:
Expand Down Expand Up @@ -253,23 +281,6 @@ def test_scan_project_skip_dirs_still_apply_without_override():
shutil.rmtree(tmpdir)


def test_entity_metadata_finds_cyrillic_names(monkeypatch):
"""Entity extraction must find non-Latin names when entity_languages includes the locale."""
import mempalace.palace as palace_mod
from mempalace.miner import _extract_entities_for_metadata

# Reset cached patterns so they reload with the monkeypatched languages
monkeypatch.setattr(palace_mod, "_CANDIDATE_RX_CACHE", None)
monkeypatch.setattr(
"mempalace.config.MempalaceConfig.entity_languages",
property(lambda self: ("en", "ru")),
)

content = "Михаил написал код. Михаил отправил PR. Михаил получил ревью."
result = _extract_entities_for_metadata(content)
assert "Михаил" in result, f"Cyrillic name not found in entity metadata: {result!r}"


def test_file_already_mined_check_mtime():
tmpdir = tempfile.mkdtemp()
try:
Expand Down