feat: support static routes #49
Conversation
api/v1alpha1/ippool_type.go
Outdated
| @@ -45,6 +45,10 @@ type IPPoolSpec struct { | |||
| Gateway string `json:"gateway,omitempty"` | |||
| // selector for nodes, if empty match all nodes | |||
| NodeSelector *corev1.NodeSelector `json:"nodeSelector,omitempty"` | |||
| // if true, add gateway as default gateway in the routes list | |||
| DefaultGateway *bool `json:"defautGateway,omitempty"` | |||
There was a problem hiding this comment.
Do we really want to use a pointer here? It looks like that "false" is a safe default
There was a problem hiding this comment.
I agree with Yury, simple boolean should be enough I think.
api/v1alpha1/validate_routes.go
Outdated
|
|
||
| // validateRoutes validate routes: | ||
| // - dst is a valid CIDR | ||
| func validateRoutes(routes []Route, fldPath *field.Path) field.ErrorList { |
There was a problem hiding this comment.
I think we should also validate that routes are from the same address family (ipv4, ipv6) as the pool
api/v1alpha1/validate_routes.go
Outdated
| func validateRoutes(routes []Route, fldPath *field.Path) field.ErrorList { | ||
| allErrs := field.ErrorList{} | ||
| for i, r := range routes { | ||
| _, _, err := net.ParseCIDR(r.Dst) |
There was a problem hiding this comment.
net.ParserCIDR parses 0.0.0.0/0 as a valid CIDR. Do we want to filter default GW here to make sure that we will not create duplicate default route entries in case if DefaultGateway is set to true and 0.0.0.0/0 is explicitly added to the routes list?
api/v1alpha1/ippool_type.go
Outdated
| @@ -45,6 +45,10 @@ type IPPoolSpec struct { | |||
| Gateway string `json:"gateway,omitempty"` | |||
| // selector for nodes, if empty match all nodes | |||
| NodeSelector *corev1.NodeSelector `json:"nodeSelector,omitempty"` | |||
| // if true, add gateway as default gateway in the routes list | |||
| DefaultGateway *bool `json:"defautGateway,omitempty"` | |||
There was a problem hiding this comment.
I agree with Yury, simple boolean should be enough I think.
rollandf
force-pushed
the
routes
branch
2 times, most recently
from
9c34adc
to
f614767
Compare
pkg/pool/reader.go
Outdated
| } | ||
|
|
||
| // RouteSlice is a type alias for a slice of Route | ||
| type RouteSlice []Route |
There was a problem hiding this comment.
nit: Do we need this type and functions below? It looks like it is not used.
Support optional static routes in the CNI CmdAdd result. Signed-off-by: Fred Rolland <[email protected]>
Support optional static routes in the CNI CmdAdd result.