Adjust CIDRPool to use int32 instead of uint fields #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the API Conventions, we should not use
uint
type for fields.In fact, issues using
uint
can also be observed when trying toDeepCopyJSON
the object that panics with errorpanic: cannot deep copy uint64
. (e.g. convert the object tounstructured.Unstructured
and then callunstructuredObj.DeepCopy()
)Upstream issue: kubernetes/kubernetes#62769
This PR adjusts the
uint
fields toint32
. This means that we can fully cover the IPv4 address family, but we impose limitations for the IPv6 address family since thegatewayIndex
andPerNodeNetworkPrefix
can go up to 2^32.