Add a controller for NicFirmwareTemplates #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almaslennikov
requested review from
adrianchiris,
ykulazhenkov and
heyvister1
Pull Request Test Coverage Report for Build 13457135054Details
💛 - Coveralls |
Signed-off-by: Alexander Maslennikov <[email protected]>
almaslennikov
force-pushed
the
fw-configuration-template-controller
branch
from
1045cf1 to
cedd770
Compare
The controller reuses the logic extracted to template_matcher.go Signed-off-by: Alexander Maslennikov <[email protected]>
almaslennikov
force-pushed
the
fw-configuration-template-controller
branch
from
cedd770 to
4a3dc9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template apply logic is very similar to the one we already have for the NicConfigurationTemplate, so let's extract it into a separate file and reuse in both controllers