Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provisioning for fw binaries #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

almaslennikov
Copy link
Collaborator

@almaslennikov almaslennikov commented Jan 17, 2025

Introduced two new CRDs: NicFirmwareSource and NicFirmwareTemplate
New controller reconciling NicFirmwareSources
firmware package with logic for provisioning firmware files on a shared storage
unit tests
change docker base image for operator to rhel to install mstflint

TBD in separate PRs:

  • support for storage classes
  • support for finalizers for NicFirmwareSource CRD

@coveralls
Copy link

coveralls commented Jan 17, 2025

Pull Request Test Coverage Report for Build 13459844076

Details

  • 481 of 687 (70.01%) changed or added relevant lines in 6 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+3.6%) to 59.661%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/manager/main.go 0 8 0.0%
pkg/firmware/mocks/ProvisioningUtils.go 58 79 73.42%
internal/controller/nicfirmwaresource_controller.go 61 83 73.49%
pkg/firmware/mocks/FirmwareProvisioner.go 64 86 74.42%
pkg/firmware/utils.go 102 154 66.23%
pkg/firmware/provisioning.go 196 277 70.76%
Files with Coverage Reduction New Missed Lines %
internal/controller/nicconfigurationtemplate_controller.go 6 86.93%
Totals Coverage Status
Change from base Build 13435211666: 3.6%
Covered Lines: 2325
Relevant Lines: 3897

💛 - Coveralls

@almaslennikov almaslennikov force-pushed the fw-provisioning branch 5 times, most recently from aa7dc94 to 13c0f57 Compare January 20, 2025 14:04
@almaslennikov almaslennikov force-pushed the fw-provisioning branch 2 times, most recently from 253e111 to 9745367 Compare January 23, 2025 10:33
@almaslennikov almaslennikov force-pushed the fw-provisioning branch 2 times, most recently from 063ccbd to 4bccd49 Compare February 3, 2025 10:33
@almaslennikov almaslennikov force-pushed the fw-provisioning branch 5 times, most recently from e03c69d to 3031a91 Compare February 4, 2025 12:02
@almaslennikov almaslennikov force-pushed the fw-provisioning branch 2 times, most recently from 39b88b9 to f030e13 Compare February 21, 2025 09:27
Introduced two new CRDs: NicFirmwareSource and NicFirmwareTemplate
New controller reconciling NicFirmwareSources
firmware package with logic for provisioning firmware files on a shared storage
unit tests

Signed-off-by: Alexander Maslennikov <[email protected]>
+ README update

Signed-off-by: Alexander Maslennikov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants