Set sriovNetworkOperator node selector in a helm chart in a safer manner #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If helm value sriovNetworkOperator.configDaemonNodeSelectorExtra map is manually removed from the default values.yaml, then wrong type for value error may occur while deploying helm chart. Signed-off-by: Yury Kulazhenkov <[email protected]>
|
This error may happen if the user replaces default helm values (values.yaml) with some old values.yaml, which has no this field. This is miss usage by the user, but from our side, it is better to set these values in a safer manner |
|
/retest-all |
adrianchiris
approved these changes
Apr 19, 2023
|
/retest-image_scan |
|
@e0ne this one is pretty straight forward can you take a look ? |
e0ne
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If helm value sriovNetworkOperator.configDaemonNodeSelectorExtra map is manually
removed from the default values.yaml, then
wrong type for value error may occur while deploying helm chart.