Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fixing nicclusterpolicy validation for empty config list #1096

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heyvister1
Copy link

bug: fixing nicclusterpolicy validation for 'RdmaSharedDevicePluginConfig.config, SriovDevicePlugin.resourceList' empty list

…nfig.config, SriovDevicePlugin.resourceList' empty list

Signed-off-by: Ido Heyvi <[email protected]>
@heyvister1
Copy link
Author

/cc @e0ne

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11232505803

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 23 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.07%) to 60.425%

Files with Coverage Reduction New Missed Lines %
pkg/state/state_hostdevice_network.go 2 75.68%
controllers/macvlannetwork_controller.go 2 86.25%
pkg/state/state_skel.go 2 84.23%
api/v1alpha1/zz_generated.deepcopy.go 4 40.38%
controllers/hostdevicenetwork_controller.go 13 77.27%
Totals Coverage Status
Change from base Build 11211050145: 0.07%
Covered Lines: 3330
Relevant Lines: 5511

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants