-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add optional deployment for Networking NIC Configuration operator #1083
Conversation
Pull Request Test Coverage Report for Build 11121743839Details
💛 - Coveralls |
603bf95
to
a25cece
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest-copy-right |
1 similar comment
/retest-copy-right |
/retest-all |
Let's have the changes from: Mellanox/nic-configuration-operator#16 once merged |
a25cece
to
e5085db
Compare
I think we need the following in the chart: |
… Operator Signed-off-by: Ivan Kolodiazhnyi <[email protected]>
e5085db
to
0ebad71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me as an alpha feature. For the next release we'll aim for a more tight integration (deploying maintenance operator etc.)
Nvidia_mlx5_ConnectX-6_Dx: "101d 24.07-0.6.1 22.42.1000" | ||
Nvidia_mlx5_ConnectX-6_Lx: "101f 24.07-0.6.1 26.42.1000" | ||
Nvidia_mlx5_ConnectX-7: "1021 24.07-0.6.1 28.42.1000" | ||
Nvidia_mlx5_MT42822_BlueField-2_integrated_ConnectX-6_Dx: "a2d6 24.07-0.6.1 24.42.1000" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@almaslennikov @e0ne missing BlueField-3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noama-nv we'll add BF3 once we'll be aware regarding the supported/tested firmware. There is only BF2 now: https://docs.nvidia.com/networking/display/mlnxofedv24070610/general+support#src-3075125780_GeneralSupport-MLNX_OFEDVersionInteroperability
No description provided.