Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add optional deployment for Networking NIC Configuration operator #1083

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

e0ne
Copy link
Collaborator

@e0ne e0ne commented Sep 25, 2024

No description provided.

@e0ne e0ne changed the title feat: Add optional deployment for NVIDIA Networking NIC Configuration… feat: Add optional deployment for Networking NIC Configuration operator Sep 25, 2024
@coveralls
Copy link
Collaborator

coveralls commented Sep 25, 2024

Pull Request Test Coverage Report for Build 11121743839

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 60.443%

Changes Missing Coverage Covered Lines Changed/Added Lines %
hack/release.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
hack/release.go 1 0.0%
Totals Coverage Status
Change from base Build 10994266668: 0.1%
Covered Lines: 3331
Relevant Lines: 5511

💛 - Coveralls

@e0ne e0ne force-pushed the nic-configuration-operator-chart branch from 603bf95 to a25cece Compare September 25, 2024 11:50
rollandf
rollandf previously approved these changes Sep 25, 2024
Copy link
Member

@rollandf rollandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rollandf
Copy link
Member

/retest-copy-right

1 similar comment
@rollandf
Copy link
Member

/retest-copy-right

@rollandf
Copy link
Member

/retest-all

@rollandf
Copy link
Member

rollandf commented Oct 1, 2024

Let's have the changes from: Mellanox/nic-configuration-operator#16 once merged

@rollandf
Copy link
Member

rollandf commented Oct 1, 2024

I think we need the following in the chart:
deployment/nic-configuration-operator-chart/templates/supported-nic-firmware-configmap.yaml

@e0ne e0ne force-pushed the nic-configuration-operator-chart branch from e5085db to 0ebad71 Compare October 1, 2024 08:40
Copy link
Collaborator

@almaslennikov almaslennikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me as an alpha feature. For the next release we'll aim for a more tight integration (deploying maintenance operator etc.)

@e0ne e0ne merged commit 95799f3 into Mellanox:master Oct 2, 2024
16 checks passed
Nvidia_mlx5_ConnectX-6_Dx: "101d 24.07-0.6.1 22.42.1000"
Nvidia_mlx5_ConnectX-6_Lx: "101f 24.07-0.6.1 26.42.1000"
Nvidia_mlx5_ConnectX-7: "1021 24.07-0.6.1 28.42.1000"
Nvidia_mlx5_MT42822_BlueField-2_integrated_ConnectX-6_Dx: "a2d6 24.07-0.6.1 24.42.1000"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@almaslennikov @e0ne missing BlueField-3?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noama-nv we'll add BF3 once we'll be aware regarding the supported/tested firmware. There is only BF2 now: https://docs.nvidia.com/networking/display/mlnxofedv24070610/general+support#src-3075125780_GeneralSupport-MLNX_OFEDVersionInteroperability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants