Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: 4213201 Nullify all WQEBB on special WQEs #323

Open
wants to merge 2 commits into
base: vNext
Choose a base branch
from

Conversation

AlexanderGrissik
Copy link
Collaborator

Description

Based on PR 321.
Correct special WQEs cleanup.

What

Fix possible issues and syndroms do to incorrect WQEBB cleanup.

Why ?

Functionality.

How ?

Always nullify the whole first WQEBB

Change type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Check list

  • Code follows the style de facto guidelines of this project
  • Comments have been inserted in hard to understand places
  • Documentation has been updated (if necessary)
  • Test has been added (if possible)

pasis and others added 2 commits March 20, 2025 15:08
XLIO does a prefetch with zeroing the next WQEBB after a doorbell. It
also presets inline_hdr_sz as a legacy behavior.

However, in a corner case when the producer fills the tail WQE and the
consumer is still processing the head WQE, the prefetch code corrupts
the head WQE.

Remove the prefetch to avoid the SQ corruption. Clear each WQE before
filling it.

Signed-off-by: Dmytro Podgornyi <[email protected]>
Nullify all WQEBB size even if the special WQE is less then 64B.

Signed-off-by: Alexander Grissik <[email protected]>
@AlexanderGrissik AlexanderGrissik requested a review from pasis March 20, 2025 13:39
@galnoam
Copy link
Collaborator

galnoam commented Mar 24, 2025

bot:retest

@galnoam galnoam added the postponed Postponed for further decisions label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postponed Postponed for further decisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants