issue: 4207451 Move from env params to config file #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerdbz
requested review from
pasis,
AlexanderGrissik,
BasharRadya and
galnoam
tomerdbz
force-pushed
the
new_config
branch
10 times, most recently
from
8d82cb0 to
73ee4a9
Compare
tomerdbz
requested review from
igor-ivanov,
AlexanderGrissik and
BasharRadya
tomerdbz
force-pushed
the
new_config
branch
2 times, most recently
from
a18146f to
ef448be
Compare
|
A.I. - before merging open ticket to devops to build and run unit_tests by: |
tomerdbz
force-pushed
the
new_config
branch
3 times, most recently
from
d6b9a43 to
e59a4a0
Compare
MVP: Move from env params to config file. This change introduces a new configuration file that will be used to configure the system. The configuration file is a JSON file that contains all the configuration parameters that were previously passed as environment variables. In the case of a failure to load the configuration file, the system will fall back to the old environment variables method. See HLD and LLD for more information. This patch also adds unit-tests for the new configuration system. Signed-off-by: Tomer Cabouly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MVP: Move from env params to config file.
This change introduces a new configuration file that will be used to configure the system.
The configuration file is a JSON file that contains all the configuration parameters that were previously passed as environment variables.
In the case of a failure to load the configuration file, the system will fall back to the old environment variables method.
See HLD and LLD for more information.
This patch also adds unit-tests for the new configuration system.
Change type
What kind of change does this PR introduce?
Check list