-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage API - listen sockets support #218
Open
pasis
wants to merge
8
commits into
Mellanox:vNext
Choose a base branch
from
pasis:storage-api-listen
base: vNext
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ac17ffc
to
b166325
Compare
5ffa993
to
114890e
Compare
Thanks for doing this. FWIW I tried using it and it seems to work pretty well, now that the xlio socket API can be used end to end... |
114890e
to
930ad2a
Compare
in_protocol_t represents several values and doens't have to be 4 bytes in size. Reducing it to 2 bytes allows to utilize flow_tuple layout more efficiently. Signed-off-by: Dmytro Podgornyi <[email protected]>
Signed-off-by: Dmytro Podgornyi <[email protected]>
Signed-off-by: Dmytro Podgornyi <[email protected]>
Signed-off-by: Dmytro Podgornyi <[email protected]>
During guided migration between xlio_poll_groups, between detach and attach operations the new RX packets arrive to the respective listen socket due to 3T steering. Drop such packets with TCP RST, so the packets can be retransmitted eventually and the TCP stream recover. Signed-off-by: Dmytro Podgornyi <[email protected]>
Hi @benjarvis, thank you for sharing your results. 200Gbits with a single TCP connection is amazing result! |
Signed-off-by: Alexander Grissik <[email protected]>
Signed-off-by: Alexander Grissik <[email protected]>
The attach_as_uc_receiver and detach_receiver assume the socket is locked. We must have a locked socket before calling to these methods. Signed-off-by: Alexander Grissik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a summary of the change.
What
Subject: what this PR is doing in one line.
Why ?
Justification for the PR. If there is existing issue/bug please reference.
How ?
It is optional but for complex PRs please provide information about the design,
architecture, approach, etc.
Change type
What kind of change does this PR introduce?
Check list