Cleanup and maintenance #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianchiris
force-pushed
the
cleanup-and-maintenance
branch
2 times, most recently
from
849de73
to
e4a2d74
Compare
adrianchiris
force-pushed
the
cleanup-and-maintenance
branch
from
e4a2d74
to
ba72d61
Compare
Pull Request Test Coverage Report for Build 10789116046Details
💛 - Coveralls |
adrianchiris
force-pushed
the
cleanup-and-maintenance
branch
2 times, most recently
from
f6bd8ff
to
44db159
Compare
adrianchiris
force-pushed
the
cleanup-and-maintenance
branch
from
44db159
to
5615e25
Compare
rollandf
approved these changes
Sep 8, 2024
almaslennikov
approved these changes
Sep 9, 2024
.golangci.yml
Outdated
| gocyclo: | ||
| min-complexity: 30 | ||
| goimports: | ||
| local-prefixes: github.com/Mellanox/maintenance-operator |
There was a problem hiding this comment.
github.com/Mellanox/ib-kubernetes?
pkg/drivers/http/client.go
Outdated
| httpClient.Transport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true} | ||
| } else { | ||
| caCertPool := x509.NewCertPool() | ||
| caCertPool.AppendCertsFromPEM([]byte(cert)) | ||
| ////nolint:gosec |
There was a problem hiding this comment.
Does the linter directive work with 4 slashes?
There was a problem hiding this comment.
well it works :) but i will stick to 2.
- remove un-needed files - rework makefile (mainly cleanup and usage of go modules and coverage) - compile plugins with coverage flags so test-coverage will work - bump go version - bump golangci-lint version and add linter config - fix lint issues in code Signed-off-by: adrianc <[email protected]>
Signed-off-by: adrianc <[email protected]>
In addition fix image push trigger branch Signed-off-by: adrianc <[email protected]>
Signed-off-by: adrianc <[email protected]>
current base image was failing on arm64 builds. we now use debian for build and distroless for the app. Signed-off-by: adrianc <[email protected]>
adrianchiris
force-pushed
the
cleanup-and-maintenance
branch
from
5615e25
to
ecda7f3
Compare
|
@almaslennikov addressed comments. merging this one once CI is green per your and @rollandf LGTMs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.