Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/collect process init status #713

Merged

Conversation

yumiguan
Copy link
Member

Collect process init status

@yumiguan yumiguan requested a review from a team November 25, 2022 09:59
if module_status == 'READY':
status_checkpoints[module] = True
else:
print('a')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个print再换一下吧

def __init__(self) -> None:
self._server_process = None
super().__init__()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果没有其他修改 可以不实现 __init__了

@yumiguan yumiguan merged commit 847f4ad into Meituan-Dianping:master Nov 28, 2022
@yumiguan yumiguan deleted the feature/collect-process-init-status branch November 28, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

能升级requests库版本吗?当前版本过低,与其他用于无法兼容
3 participants