Added Rabin Miller primality test code, as well as added tests for it… #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (no failing tests, just passing tests for now).
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 87.21% 87.26% +0.05%
==========================================
Files 7 8 +1
Lines 1650 1688 +38
Branches 300 309 +9
==========================================
+ Hits 1439 1473 +34
- Misses 151 153 +2
- Partials 60 62 +2 |
|
Excellent! I'll start working on transitioning over to MR for large primes. |
|
@misingnoglic It seems I prematurely accepted this PR. I meant for the MR implementation to use the deterministic variant that uses specific witnesses to prove primality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (no failing tests, just passing tests for now).
#86