Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devops: fix action for ubuntu-latest and invariant culture in tests #5974

Merged

Conversation

tesar-tech
Copy link
Collaborator

@tesar-tech tesar-tech commented Feb 15, 2025

Original problem: #5940 (comment)

The error was this:

Assert.Equal() Failure: Strings differ
                              ↓ (pos 19)
Expected: "12/31/9999 11:59:59 PM"
Actual:   "12/31/9999 11:59:59 PM"
                              ↑ (pos 19)


Explanation:

At position 19, the space before "PM" is different:

    The expected value has a regular space (U+0020).
    The actual value has a narrow no-break space (U+202F), which looks visually similar but is a different Unicode character.

It is culture dependent. I don't exactly know why that was happening in ubuntu 24 not 22...

This fix makes the tests more deterministic.

I re-discovered the issue by an accident. And fixing it till it's in fresh memory...

@tesar-tech tesar-tech requested a review from stsrki February 15, 2025 12:07
@stsrki stsrki changed the title Devops: ubuntu-latest is back with invariant culture fix in tests Devops: fix action for ubuntu-latest and invariant culture in tests Feb 17, 2025
@stsrki stsrki merged commit 4ff8484 into master Feb 17, 2025
2 checks passed
@stsrki stsrki deleted the dev/fix-add-invariant-culture-to-test-fixes-ubuntu-latest branch February 17, 2025 10:11
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants