Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove validator APIs that are not supported #5692

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Remove validator APIs that are not supported #5692

merged 1 commit into from
Aug 17, 2024

Conversation

stsrki
Copy link
Collaborator

@stsrki stsrki commented Aug 14, 2024

Closes #5690

I have, by mistake, added some validation helper APIs that are not supported.

@stsrki stsrki requested a review from David-Moreira August 14, 2024 11:47
This was referenced Aug 14, 2024
Closed
Open
David-Moreira
David-Moreira approved these changes Aug 17, 2024
View reviewed changes
Copy link
Contributor

@David-Moreira David-Moreira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these not supported? Feels weird to remove something that was already introduced?

Edit: I understand you added by mistake, but how hard would it be to just make them work?

@stsrki
Copy link
Collaborator Author

stsrki commented Aug 17, 2024

Edit: I understand you added by mistake, but how hard would it be to just make them work?

We would have to introduce a new Validator API that uses a generic T parameter. But since that is possible only in the next major version, I would rather remove it for now.

@stsrki stsrki merged commit a0469ce into rel-1.6 Aug 17, 2024
2 checks passed
@stsrki stsrki deleted the rel-1.6-remove-unsuported-apis branch August 17, 2024 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@David-Moreira David-Moreira David-Moreira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsrki @David-Moreira