-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PdfViewer component #5676
PdfViewer component #5676
Conversation
It should be mostly done feature-wise. Please review. |
# Conflicts: # Documentation/Blazorise.Docs/Pages/News/2024-10-15-release-notes-170.razor
State Class? If we allow a state for each one of the components, the user can just provide different states for both the toolbar and pdf viewer, is this ever what we want? Also I opened the State class expect a bunch of state, and all I see is events? Are we sure we are conveying the expected meaning? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...entation/Blazorise.Docs/Pages/Docs/Extensions/PdfViewer/Examples/PdfViewerBasicExample.razor
Show resolved
Hide resolved
Documentation/Blazorise.Docs/Pages/Docs/Extensions/PdfViewer/PdfViewerPage.razor
Outdated
Show resolved
Hide resolved
Documentation/Blazorise.Docs/Pages/Docs/Extensions/PdfViewer/PdfViewerPage.razor
Outdated
Show resolved
Hide resolved
Documentation/Blazorise.Docs/Pages/Docs/Extensions/PdfViewer/PdfViewerPage.razor
Show resolved
Hide resolved
Source/Extensions/Blazorise.PdfViewer/PdfViewerToolbar.razor.cs
Outdated
Show resolved
Hide resolved
The container should keep the same size no matter the zoom level.
It might be a good thing to have. I'll see 🤔
For this we would have to have more work with the scaling math in the JS. For the first version of PdfViewer, I want to first publish it and then see what to focus on once the users start using it. |
As long as the user defines the absolute URL path this should work. Not sure if we need an example in the docs or leave it to the user to figure it. |
Is there a specific reason for this? |
I don't understand why you need to do calcs for this. Can't outside divs autosize according to the inner content dimensions? That is by using the appropriate css rules, of course. |
Personally I'd expect it to work with relative urls, just like an image src or an anchor tag, but this isn't easily possible as I understand? |
Because pdf.js works that way. We would need to calculate scale for the page viewport based on the canvas size, and page scrolling area. I checked into their own viewer code. And I tell you, it doesn't look friendly at all to figure it out. |
I see. Thanks for explaining, sometimes things seem easier then what they are. |
Closes #598