Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nugets #317

Merged
merged 4 commits into from
Oct 16, 2019
Merged

Fix nugets #317

merged 4 commits into from
Oct 16, 2019

Conversation

stsrki
Copy link
Collaborator

@stsrki stsrki commented Oct 16, 2019

The reason behind this PR is that dotnet pack is not working for referenced projects. And since every project is referencing Blazorise.csproj it means almost every nuget package will be invalid.

To overcome this limitation I have constructed .nuspec files to generate valid .nupkg files based on the dotnet pack.

This is only a workaround until hopefully dotnet pack is fixed. dotnet/aspnetcore#14467

@stsrki stsrki merged commit 0c8242d into master Oct 16, 2019
@stsrki stsrki deleted the fix-nugets branch October 16, 2019 11:48
@jzabroski
Copy link

jzabroski commented Oct 16, 2019 via email

@stsrki
Copy link
Collaborator Author

stsrki commented Oct 16, 2019

I really don't know if there is a better way to handle this. I have tried to find it but eventually had to come up with this workaround or otherwise I would lose too much time until I release the new version.

@stsrki
Copy link
Collaborator Author

stsrki commented Oct 16, 2019

PS. I like FluentMigrator a lot and being using it for all my personal and work projects 👍

@jzabroski
Copy link

@stsrki Maybe we should submit an RFP to dotnetcli project and elaborate our needs? It really sucks having to do verbose solutions like this. I have run into this problem twice myself now. The other situation was in a private work project dedicated to running PowerShell C# binary cmdlets. Pack only packs the main file, but I need to pack everything in order to have my psd1 RequiredModules references all there. My hack for now is to just download the dll with NuGet and save it to a lib folder in PowerShell. That's "ok" for slowly changing dependencies like third party libs, but for a "global build at head" like a Solution file with all related projects moving a GlobalAssemblyInfo.cs AssemblyVersionAttribute in sync across all projects in the Solution, it SUCKS!

@stsrki
Copy link
Collaborator Author

stsrki commented Oct 16, 2019

Yeah I think RFP on dotnetcli project would be the better route instead of in AspNetCore.

For me it's really strange that dotnet pack doesn't support referenced projects as I think it should be a fairly common scenario.

@jzabroski
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants