Skip to content

passing interpreter_name to fail_fast #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025
Merged

passing interpreter_name to fail_fast #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
221b922
add interpreterName
archit-meesho Aug 6, 2025
944ec6c
fail fast
archit-meesho Aug 7, 2025
bd444bb
fixed fail_fast
Vishvas-meesho Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ private InterpreterResult executeSql(String dbPrefix, String sql,
.replace("\n", " ")
.replace("\r", " ")
.replace("\t", " ");
ValidationRequest request = new ValidationRequest(sqlToValidate, userName);
ValidationRequest request = new ValidationRequest(sqlToValidate, userName, interpreterName);
try {
ValidationResponse response = sendValidationRequest(request);
if (response.isPreSubmitFail()) {
Expand Down Expand Up @@ -916,6 +916,9 @@ private InterpreterResult executeSql(String dbPrefix, String sql,
finalOutput.append("Use: ").append(jsonObject.getString(table)).append(" in place of ").append(table).append("\n");
}
}
}else if (outputMessage.contains("UnAuthorized Query")) {
context.out.write("Query Error: UnAuthorized Query\n");
finalOutput.append("You are not authorized to execute this query.\n");
}
context.getLocalProperties().put(CANCEL_REASON, finalOutput.toString());
cancel(context);
Expand Down
6 changes: 4 additions & 2 deletions jdbc/src/main/java/org/apache/zeppelin/jdbc/ValidationRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,16 @@
public class ValidationRequest {
private String queryText;
private String user;
private String interpreterName;

public ValidationRequest(String queryText, String user) {
public ValidationRequest(String queryText, String user, String interpreterName) {
this.queryText = queryText;
this.user = user;
this.interpreterName = interpreterName;
}

public String toJson() {
return "{\"query_text\":\"" + queryText + "\",\"user\":\"" + user + "\"}";
return "{\"query_text\":\"" + queryText + "\",\"user\":\"" + user + "\",\"interpreter_name\":\"" + interpreterName + "\"}";
}
}