This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Prevent replacement of global.Promise in node v4 #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently by requiring `phantomjs-prebuilt`, the original Promise is replaced by the `es6-promise` module.
In es6-promise v4.0.3 this has been fixed and we should incorporate it.
How to reproduce the current behavior?
```
> console.log(Promise)
[Function: Promise]
> require('phantomjs-prebuilt')
> console.log(Promise)
{ [Function: lib$es6$promise$promise$$Promise]
all: [Function: lib$es6$promise$promise$all$$all],
race: [Function: lib$es6$promise$promise$race$$race],
resolve: [Function: lib$es6$promise$promise$resolve$$resolve],
reject: [Function: lib$es6$promise$promise$reject$$reject],
_setScheduler: [Function: lib$es6$promise$asap$$setScheduler],
_setAsap: [Function: lib$es6$promise$asap$$setAsap],
_asap: [Function: asap] }
```
|
thanks! |
|
published as 2.1.13 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently by requiring
phantomjs-prebuilt, the original Promise is replaced by thees6-promisemodule.This has been fixed in es6-promise v4.0.3 and we should incorporate it.
How to reproduce the current behavior?