Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

details: support built-in Hugo shortcode #957

Closed
McShelby opened this issue Dec 1, 2024 · 2 comments
Closed

details: support built-in Hugo shortcode #957

McShelby opened this issue Dec 1, 2024 · 2 comments
Assignees
@McShelby
Labels
feature New feature or request hugo This is a topic related to Hugo itself but not the theme
Milestone
7.3.0

Comments

@McShelby
Copy link
Owner

McShelby commented Dec 1, 2024

The next version of Hugo (probably 0.140) will contain the new built-in shortcode details.

The theme will provide a compatible implementation leveraging the expand shortcode.
@McShelby McShelby added feature New feature or request hugo This is a topic related to Hugo itself but not the theme labels Dec 1, 2024
@McShelby McShelby added this to the 7.2.0 milestone Dec 1, 2024
@McShelby McShelby self-assigned this Dec 1, 2024
McShelby added a commit that referenced this issue Dec 1, 2024
@McShelby
details: support built-in Hugo shortcode #957

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
b03a0f5
McShelby added a commit that referenced this issue Dec 1, 2024
@McShelby
docs: details shortcode #957
Loading
Loading status checks…
fc76499
@McShelby McShelby closed this as completed Dec 1, 2024
McShelby added a commit that referenced this issue Dec 1, 2024
@McShelby
notice: fix broken color parameter #957
Loading
Loading status checks…
d3bf75b
McShelby added a commit that referenced this issue Dec 1, 2024
@McShelby
docs: compat statement #957
Loading
Loading status checks…
be85052
@McShelby McShelby reopened this Dec 7, 2024
@McShelby McShelby removed this from the 7.2.0 milestone Dec 7, 2024
@McShelby
Copy link
Owner Author

McShelby commented Dec 7, 2024

As Hugo is still deciding how to implement it, I'll remove this for now. We can include this easily later

McShelby added a commit that referenced this issue Dec 7, 2024
@McShelby
details: remove shortcode for now #957
Loading
Loading status checks…
544df5e 
due to security considerations regarding the proposed implementation
in the Hugo repo
@McShelby McShelby added undecided No decission was made yet and removed undecided No decission was made yet labels Dec 7, 2024
@McShelby McShelby added this to the 7.2.2 milestone Dec 13, 2024
@McShelby
Copy link
Owner Author

The details shortcode is coming with the next Hugo release, so let's go.

McShelby added a commit that referenced this issue Dec 15, 2024
@McShelby
details: add shortcode #957
Loading
Loading status checks…
66f4fbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@McShelby McShelby

Labels
feature New feature or request hugo This is a topic related to Hugo itself but not the theme
Projects
None yet
Milestone
7.3.0
Development

No branches or pull requests
1 participant
@McShelby