Update PHP composer packages + ran recipes#1727
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
OK.. I went for the first option.. Meaning admins do need to change their |
…e Environment variable not found: "DEFAULT_URI".
src/MessageHandler/Notification/SentNewSignupNotificationHandler.php
Outdated
Show resolved
Hide resolved
|
Apparently I have not read the description or comments close enough, sorry @melroy89 |
No problem ❤️ |
|
Since we previously had issue with symfony 7.3 and docker in production it would be really helpful if someone running docker in prod could test that this is working as expected. Could you maybe do that @jwr1 ? |
|
I ran this patch on kbin.melroy.org for two days, but I notice that the content was not federating anymore. Yes RabbitMQ just worked fine and there seems to be a connection. Yet the content does not federate anymore 😢 . I first saw some error messages regarding I will need to look into deeper why it suddenly stop federating. Or maybe make smaller PRs 🤣 |
|
As one of the users on the instance who were affected, I'd like to note (FWIW; this might just be standard ActivityPub behavior) that unlike federation delays, posts (and comment and whatnot) made during the non-federated period did not federate even after federation started working again |
yeah sorry about that. I believe the message itself was also wrongly formatted (eg. the url was |
|
@melroy89 maybe we can set the |
I'm afraid I will just start over.. since for some reason after this federation doesn't work. Its hard to pin point, unless you know why. So I will just break up this PR is smaller chunks of upgrades. |
Very long overdue.. But important nonetheless, upgrading several PHP composer packages (meaning also upgrading from Symfony v7.2 to v7.3). Plus ran multiple recipes as well.
I also upgraded the
friendsofphp/php-cs-fixerCLI within thetoolsdirectory from v3.75.0 to v3.87.2 and ran thefixcommand.Last but not least, due to the
symfony/routingrecipe upgrade. A new env var was introduced, calledDEFAULT_URI. I notice an issue within your post-upgrade script that first was trying to runcomposer install(which also doescache:clearat the end), causing issues like:This can be avoided, by first running the
composer dump-env prod, so the new env var is present. Followed by thecomposer installscript :)