Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Make some edge cases of not-supported or invalid mechanisms more uniform #9821

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Backport 2.28: Make some edge cases of not-supported or invalid mechanisms more uniform #9821

merged 1 commit into from
Dec 11, 2024

Conversation

gilles-peskine-arm
Copy link
Contributor

Continuation of #9025, fixing a test bug that we only noticed later.

PR checklist

@gilles-peskine-arm
Fix copypasta
e681a4e 
Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm added bug needs-review Every commit must be reviewed by at least two team members, component-crypto Crypto primitives and low-level interfaces needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Dec 2, 2024
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Dec 2, 2024
Merged
5 tasks
@davidhorstmann-arm davidhorstmann-arm self-requested a review December 3, 2024 10:51
davidhorstmann-arm
davidhorstmann-arm approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@davidhorstmann-arm davidhorstmann-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

yanesca
yanesca approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanesca yanesca added approved Design and code approved - may be waiting for CI or backports needs-backports Backports are missing or are pending review and approval. and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Dec 9, 2024
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Dec 10, 2024
Merged
5 tasks
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue Dec 11, 2024
Merged via the queue into Mbed-TLS:mbedtls-2.28 with commit 9b1ec06 Dec 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhorstmann-arm davidhorstmann-arm davidhorstmann-arm approved these changes

@yanesca yanesca yanesca approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-crypto Crypto primitives and low-level interfaces needs-backports Backports are missing or are pending review and approval. priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)
Projects
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gilles-peskine-arm @yanesca @davidhorstmann-arm