Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed redefination warning messages for _GNU_SOURCE #9026

Merged
merged 2 commits into from
May 6, 2024
Merged

Fixed redefination warning messages for _GNU_SOURCE #9026

merged 2 commits into from
May 6, 2024

Conversation

nileshkale123
Copy link
Contributor

@nileshkale123 nileshkale123 commented Apr 12, 2024 •
edited by tom-cosgrove-arm
Loading

Description

This commit solves the issue of redefinition warning messages for _GNU_SOURCE while building on Linux platform.

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@nileshkale123 nileshkale123 force-pushed the fix/redefination_warning_for_gnu_source branch 2 times, most recently from 3ec847e to ccde252 Compare April 12, 2024 07:26
@yanesca yanesca added bug needs-review Every commit must be reviewed by at least two team members, needs-backports Backports are missing or are pending review and approval. component-crypto Crypto primitives and low-level interfaces needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most) labels Apr 12, 2024
yanesca
yanesca requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nileshkale123, thank you for your contribution.

After fixing the superfluous empty line, could you please raise backport PRs against the mbedtls-2.28 and mbedtls-3.6 branches?

ChangeLog.d/fix-redefination_warning_messages_for_GNU_SOURCE.txt Outdated Show resolved Hide resolved
@nileshkale123 nileshkale123 force-pushed the fix/redefination_warning_for_gnu_source branch from ccde252 to 6e07213 Compare April 18, 2024 05:27
yanesca
yanesca requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a newline character missing from the end of the last line which makes the CI fail. Could you please fix that?

ChangeLog.d/fix-redefination_warning_messages_for_GNU_SOURCE.txt Outdated Show resolved Hide resolved
@nileshkale123 nileshkale123 force-pushed the fix/redefination_warning_for_gnu_source branch from 6e07213 to 6bf33a8 Compare April 19, 2024 05:02
@yanesca
Copy link
Contributor

yanesca commented Apr 22, 2024

The CI was still failing, I have pushed a commit with a fix, I hope you don't mind.

yanesca
yanesca previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanesca yanesca removed the needs-ci Needs to pass CI tests label Apr 22, 2024
@tom-daubney-arm tom-daubney-arm self-requested a review April 22, 2024 11:06
@tom-daubney-arm tom-daubney-arm removed the needs-reviewer This PR needs someone to pick it up for review label Apr 22, 2024
tom-daubney-arm
tom-daubney-arm requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a couple of small typos.

ChangeLog.d/fix-redefination_warning_messages_for_GNU_SOURCE.txt Outdated Show resolved Hide resolved
ChangeLog.d/fix-redefination_warning_messages_for_GNU_SOURCE.txt Outdated Show resolved Hide resolved
@tom-daubney-arm tom-daubney-arm added needs-work and removed needs-review Every commit must be reviewed by at least two team members, labels Apr 22, 2024
@nileshkale123 nileshkale123 force-pushed the fix/redefination_warning_for_gnu_source branch from 01acb38 to d338d01 Compare April 30, 2024 02:55
yanesca
yanesca previously approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tom-cosgrove-arm
tom-cosgrove-arm requested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failure is relevant:

[2024-04-30T08:35:15.580Z] ******************************************************************
[2024-04-30T08:35:15.580Z] * check_files: Check: file sanity checks (permissions, encodings) 
[2024-04-30T08:35:15.580Z] * Tue Apr 30 08:35:15 UTC 2024
[2024-04-30T08:35:15.580Z] ******************************************************************
[2024-04-30T08:35:22.185Z] Trailing whitespace:
[2024-04-30T08:35:22.185Z] ChangeLog.d/fix-redefination_warning_messages_for_GNU_SOURCE.txt: 2, 3
[2024-04-30T08:35:22.185Z] 
[2024-04-30T08:35:22.185Z] ^^^^check_files: Check: file sanity checks (permissions, encodings): tests/scripts/check_files.py -> 1^^^^

Please remove the trailing whitespace in ChangeLog.d/fix-redefination_warning_messages_for_GNU_SOURCE.txt

@yanesca
Fix Changelog formatting
93f20f4 
Add EOL and remove trailing whitespaces.

Signed-off-by: Janos Follath <[email protected]>
@nileshkale123 nileshkale123 force-pushed the fix/redefination_warning_for_gnu_source branch from ded1d4e to 3c28bba Compare April 30, 2024 09:32
@yanesca yanesca force-pushed the fix/redefination_warning_for_gnu_source branch from 3c28bba to 93f20f4 Compare April 30, 2024 09:33
@tom-cosgrove-arm tom-cosgrove-arm mentioned this pull request Apr 30, 2024
Merged
3 tasks
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backports to 3.6 and 2.28 are still required

@tom-cosgrove-arm tom-cosgrove-arm added needs-review Every commit must be reviewed by at least two team members, and removed needs-work labels Apr 30, 2024
tom-daubney-arm
tom-daubney-arm approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@tom-daubney-arm tom-daubney-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-daubney-arm tom-daubney-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels May 1, 2024
@tom-cosgrove-arm
Copy link
Contributor

@nileshkale123 Are you able to create the backports for the mbedtls-2.28 and mbedtls-3.6 branches?

@nileshkale123
Copy link
Contributor Author

@nileshkale123 Are you able to create the backports for the mbedtls-2.28 and mbedtls-3.6 branches?

Yes, I have created MR with issue ID 9085 & 9086

This was referenced May 2, 2024
Merged
Merged
@gilles-peskine-arm gilles-peskine-arm added this pull request to the merge queue May 6, 2024
Merged via the queue into Mbed-TLS:development with commit ca73fc6 May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

@tom-daubney-arm tom-daubney-arm tom-daubney-arm approved these changes

@yanesca yanesca yanesca left review comments

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports bug component-crypto Crypto primitives and low-level interfaces needs-backports Backports are missing or are pending review and approval. size-xs Estimated task size: extra small (a few hours at most)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nileshkale123 @yanesca @tom-cosgrove-arm @tom-daubney-arm @gilles-peskine-arm