2.28 only: tests/test_suite_ecp: Fix ECP group compare test #7907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gowthamsk-arm
added
priority-medium
gilles-peskine-arm
requested changes
Jul 11, 2023
tests/suites/test_suite_ecp.function
Outdated
| @@ -64,9 +64,6 @@ inline static int mbedtls_ecp_group_cmp(mbedtls_ecp_group *grp1, | |||
| if (grp1->T_size != grp2->T_size) { | |||
There was a problem hiding this comment.
Why are we comparing T_size but not T? Doesn't T_size also depend on the state of the group structure? (AFAICT from reading ecp.c, it does.)
On a related note, please add a comment explaining why we are not comparing T here.
There was a problem hiding this comment.
Yes, it does. I missed T_size here. Will update it and add a comment. :)
gowthamsk-arm
dismissed stale reviews from tgonzalezorlandoarm and mpg
via
24a1b36
gowthamsk-arm
force-pushed
the
fix_ecp_group_compare
branch
from
a8592c7 to
24a1b36
Compare
ECP group compare function should not check the value of T. We only need to assert the value of T after the ECP group copy function is called. Signed-off-by: Gowtham Suresh Kumar <[email protected]>
gowthamsk-arm
force-pushed
the
fix_ecp_group_compare
branch
from
24a1b36 to
21f2b7a
Compare
gilles-peskine-arm
added
needs-review
gowthamsk-arm
added
approved
gilles-peskine-arm
changed the title
|
The task requires both a PR to development and a PR to 2.28, but they're going to be very different, so there's no reason to wait until development is ready, we can merge the 2.28 PR independently. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ECP group compare function should not check the value of T. We only need to assert the value of T after the ECP group copy function is called.
Relates to #6707.
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")
Notes for the submitter
Please refer to the contributing guidelines, especially the
checklist for PR contributors.