buffer: stricter isEncoding

Due to code consolidation in nodejs#7207 the isEncoding function got less strict. This commit makes sure isEncoding returns false for empty strings as before the consolidation. PR-URL: nodejs#18790 Refs: nodejs#7207 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
MayaLekova · May 8, 2018 · ad161a2 · ad161a2
1 parent b454cba
commit ad161a2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -427,7 +427,7 @@ Buffer.compare = function compare(a, b) {
 
 
 Buffer.isEncoding = function isEncoding(encoding) {
-  return typeof encoding === 'string' &&
+  return typeof encoding === 'string' && encoding.length !== 0 &&
          normalizeEncoding(encoding) !== undefined;
 };
 Buffer[kIsEncodingSymbol] = Buffer.isEncoding;