Skip to content

Conversation

@AlisskaPie
Copy link

No description provided.

@AlisskaPie AlisskaPie requested a review from IlyaFaer November 4, 2020 18:54
@AlisskaPie AlisskaPie marked this pull request as ready for review November 4, 2020 18:54
Copy link
Collaborator

@IlyaFaer IlyaFaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Few comments.

Copy link
Author

@AlisskaPie AlisskaPie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review

LastName STRING(1024),
SingerInfo BYTES(MAX)
) PRIMARY KEY (SingerId)"""
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably could move data insertion into the test to shorten the sample, but that is something to ask googlers.

@IlyaFaer IlyaFaer force-pushed the master branch 3 times, most recently from 1f4932d to 8183247 Compare November 26, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants